Make sure all sample metadata columns are compatible before merging #252
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was noticing a recurring error when trying to run the merged workflow with the latest version of scpcaTools. Specifically I was getting the following error about the
age
columns:In digging into this a little more, I was working with two processed objects that had differing types of
age
columns. One hadcharacter
and the other haddouble
. This is probably because we updated how we deal with theage
column in https://github.com/AlexsLemonade/ScPCA-admin/pull/722. To avoid any future conflicts between the types of columns, I am converting them all to characters before creating the combined sample metadata.I checked with what's going on in #251 and it looks like this section hasn't been touched, so it shouldn't cause any conflicts.