Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish other non-squashed changes #385

Closed
wants to merge 34 commits into from
Closed

Conversation

cansavvy
Copy link
Contributor

@cansavvy cansavvy commented Dec 1, 2020

Changes Being Published

Trying to get all the un-squashed commits published from #383 so then we can continue on with publishing by squashed commits

I did this by hard resetting a branch born from staging to the commit where commits start being squashed 6e57f15

List of Commits/PR's Included

This is quite unclear since these are unsquashed.

It looks like there's some github actions changes, some issue template changes (#319), and the google analytics adds (#281).

Publishing Checklist:

The html preview is not relevant in this instance.
- [ ] Does everything look good using html preview -- having taken a particularly close look at any new html files?

There's no new examples in this PR, so this not relevant.
- [ ] Have any new examples been added to the refinebio-examples feedback survey? Ideally, don't click publish until this PR is merged (changes are autosaved).

cansavvy and others added 30 commits October 7, 2020 15:13
* Update github actions to reflect staging branch

* Add libglpk40 to Dockerfile

* Make it gh-pages-stages!

* Remove dockerfile change that should have been on its own all along

* Does this work?

* Declare a uses

* Switch how env is declared

* Force it to run so we can test it

* try no curly brackets

* What's up with the branch

* Move to bash if instead

* Need quotes?

* forgot a `then`

* Try dollar signs

* Doesn't like the `.`?

* Use curly brackets

* Try ${GITHUB_REF}

* Try ${BRANCH_NAME}

* try ${GITHUB_REF#refs/*/}

* use jashapiro suggestion

* Change to base ref

* Change back to `github.ref`

* Get rid of PR `on:`

* Try another test

* Docker dep fix: Add lib package 40 thing that clusterprofiler needs (#316)

* Add lib package 40 thing that clusterprofiler needs

* Try adding options(warn = 2)

* Test if options(warn =2) means it breaks like it should

* Revert "Test if options(warn =2) means it breaks like it should"

This reverts commit d9f688f.

* Revert "Try another test"

This reverts commit 845cf1a.
* Try adding google analytics

* Add to header using includes

* temporary file snuck in there

* Restore master version so they aren't in the review

* Let's call an html file and html file

* Docker dep fix: Add lib package 40 thing that clusterprofiler needs (#316)

* Add lib package 40 thing that clusterprofiler needs

* Try adding options(warn = 2)

* Test if options(warn =2) means it breaks like it should

* Revert "Test if options(warn =2) means it breaks like it should"

This reverts commit d9f688f.
For simplicity, we will now run this even if the dockerfile hasn't changed.
Okay, so the branch name is now inaccurate, but that is fine...
Made changes to css/navbar.html
Tried to add the logo but it but it cuts out and not sure how to make it decent.
…g-docker

Stop staging from pushing to dockerhub
jashapiro and others added 4 commits October 22, 2020 12:16
Bring refine.bio fashion to staging too: attempt 2
* Add some rough draft issue templates

* Incorporate cbethell review

* Get rid of `Other` labels that aren't useful
@cansavvy cansavvy requested a review from jashapiro December 1, 2020 15:26
@cansavvy
Copy link
Contributor Author

cansavvy commented Dec 1, 2020

Oh. So there's not actually changes that haven't been merged to master???

@cansavvy cansavvy removed the request for review from jashapiro December 1, 2020 15:28
@cansavvy cansavvy closed this Dec 1, 2020
@cansavvy cansavvy reopened this Dec 1, 2020
@cansavvy cansavvy closed this Dec 1, 2020
@cansavvy cansavvy deleted the publish-other-changes branch December 1, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants