-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish other non-squashed changes #385
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update github actions to reflect staging branch * Add libglpk40 to Dockerfile * Make it gh-pages-stages! * Remove dockerfile change that should have been on its own all along * Does this work? * Declare a uses * Switch how env is declared * Force it to run so we can test it * try no curly brackets * What's up with the branch * Move to bash if instead * Need quotes? * forgot a `then` * Try dollar signs * Doesn't like the `.`? * Use curly brackets * Try ${GITHUB_REF} * Try ${BRANCH_NAME} * try ${GITHUB_REF#refs/*/} * use jashapiro suggestion * Change to base ref * Change back to `github.ref` * Get rid of PR `on:` * Try another test * Docker dep fix: Add lib package 40 thing that clusterprofiler needs (#316) * Add lib package 40 thing that clusterprofiler needs * Try adding options(warn = 2) * Test if options(warn =2) means it breaks like it should * Revert "Test if options(warn =2) means it breaks like it should" This reverts commit d9f688f. * Revert "Try another test" This reverts commit 845cf1a.
* Try adding google analytics * Add to header using includes * temporary file snuck in there * Restore master version so they aren't in the review * Let's call an html file and html file * Docker dep fix: Add lib package 40 thing that clusterprofiler needs (#316) * Add lib package 40 thing that clusterprofiler needs * Try adding options(warn = 2) * Test if options(warn =2) means it breaks like it should * Revert "Test if options(warn =2) means it breaks like it should" This reverts commit d9f688f.
For simplicity, we will now run this even if the dockerfile hasn't changed.
This reverts commit 6a38574.
Okay, so the branch name is now inaccurate, but that is fine...
Made changes to css/navbar.html Tried to add the logo but it but it cuts out and not sure how to make it decent.
…g-docker Stop staging from pushing to dockerhub
Bring refine.bio fashion to staging too: attempt 2
* Add some rough draft issue templates * Incorporate cbethell review * Get rid of `Other` labels that aren't useful
Oh. So there's not actually changes that haven't been merged to master??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Being Published
Trying to get all the un-squashed commits published from #383 so then we can continue on with publishing by squashed commits
I did this by hard resetting a branch born from staging to the commit where commits start being squashed 6e57f15
List of Commits/PR's Included
This is quite unclear since these are unsquashed.
It looks like there's some github actions changes, some issue template changes (#319), and the google analytics adds (#281).
Publishing Checklist:
The html preview is not relevant in this instance.
- [ ] Does everything look good using html preview -- having taken a particularly close look at any new html files?There's no new examples in this PR, so this not relevant.
- [ ] Have any new examples been added to the refinebio-examples feedback survey? Ideally, don't click publish until this PR is merged (changes are autosaved).