Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant memory traffic #7100

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/convolutional_layer.c
Original file line number Diff line number Diff line change
Expand Up @@ -711,7 +711,7 @@ convolutional_layer make_convolutional_layer(int batch, int steps, int h, int w,
if (train) l.bias_updates_gpu = cuda_make_array(l.bias_updates, n);
}

l.output_gpu = cuda_make_array(l.output, total_batch*out_h*out_w*n);
l.output_gpu = cuda_make_array_init2zero(total_batch*out_h*out_w*n);
if (train) l.delta_gpu = cuda_make_array(l.delta, total_batch*out_h*out_w*n);

if(binary){
Expand Down Expand Up @@ -755,9 +755,9 @@ convolutional_layer make_convolutional_layer(int batch, int steps, int h, int w,
}

if (train) {
l.x_gpu = cuda_make_array(l.output, total_batch*out_h*out_w*n);
l.x_gpu = cuda_make_array_init2zero(total_batch*out_h*out_w*n);
#ifndef CUDNN
l.x_norm_gpu = cuda_make_array(l.output, total_batch*out_h*out_w*n);
l.x_norm_gpu = cuda_make_array_init2zero( total_batch*out_h*out_w*n);
#endif // CUDNN
}
}
Expand Down
17 changes: 17 additions & 0 deletions src/dark_cuda.c
Original file line number Diff line number Diff line change
Expand Up @@ -487,6 +487,23 @@ float *cuda_make_array(float *x, size_t n)
return x_gpu;
}

float *cuda_make_array_init2zero(size_t n) {
float *x_gpu;
size_t size = sizeof(float) * n;
cudaError_t status = cudaMalloc((void **)&x_gpu, size);
// cudaError_t status = cudaMallocManaged((void **)&x_gpu, size,
// cudaMemAttachGlobal); status = cudaMemAdvise(x_gpu, size,
// cudaMemAdviseSetPreferredLocation, cudaCpuDeviceId);
if (status != cudaSuccess)
fprintf(stderr, " Try to set subdivisions=64 in your cfg-file. \n");
CHECK_CUDA(status);
// status = cudaMemcpy(x_gpu, x, size, cudaMemcpyHostToDevice);
status =cudaMemsetAsync(x_gpu, 0, size, 0);
CHECK_CUDA(status);
if (!x_gpu) error("Cuda malloc failed", DARKNET_LOC);
return x_gpu;
}

void **cuda_make_array_pointers(void **x, size_t n)
{
void **x_gpu;
Expand Down
1 change: 1 addition & 0 deletions src/dark_cuda.h
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ extern "C" {
float *cuda_make_array_pinned_preallocated(float *x, size_t n);
float *cuda_make_array_pinned(float *x, size_t n);
float *cuda_make_array(float *x, size_t n);
float *cuda_make_array_init2zero(size_t n);
void **cuda_make_array_pointers(void **x, size_t n);
int *cuda_make_int_array(size_t n);
int *cuda_make_int_array_new_api(int *x, size_t n);
Expand Down
4 changes: 2 additions & 2 deletions src/route_layer.c
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ route_layer make_route_layer(int batch, int n, int *input_layers, int *input_siz
l.forward_gpu = forward_route_layer_gpu;
l.backward_gpu = backward_route_layer_gpu;

l.delta_gpu = cuda_make_array(l.delta, outputs*batch);
l.output_gpu = cuda_make_array(l.output, outputs*batch);
l.delta_gpu = cuda_make_array_init2zero(outputs*batch);
l.output_gpu = cuda_make_array_init2zero(outputs*batch);
#endif
return l;
}
Expand Down