Make the footer width adjustable per page. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets a default `footerWidthClass` stash value to `col-12` in the
ContentGenerator `go` method. Any module or template can modify that as
needed to match its layout. This is done in
`templates/ContentGenerator/Instructor/Index.html.ep`,
`templates/ContentGenerator/Instructor/Stats/index.html.ep`, and
`templates/ContentGenerator/Problem.html.ep`.
Note that this can also be done directly in the perl code for any
package that derives from the ContentGenerator as well (i.e., in a `.pm`
file). To do so call `$c->stash->{footerWidthClass} = '...'`.
I have left the remaining pages for you to determine, since I am
uncertain what you will want on some of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets a default
footerWidthClassstash value tocol-12in the ContentGeneratorgomethod. Any module or template can modify that as needed to match its layout. This is done intemplates/ContentGenerator/Instructor/Index.html.ep,templates/ContentGenerator/Instructor/Stats/index.html.ep, andtemplates/ContentGenerator/Problem.html.ep.Note that this can also be done directly in the perl code for any package that derives from the ContentGenerator as well (i.e., in a
.pmfile). To do so call$c->stash->{footerWidthClass} = '...'.I have left the remaining pages for you to determine, since I am uncertain what you will want on some of them.