More suggestions. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch the new `filterRecords` parameter to a boolean, and adjust the radio values to make that easier to work with. Place the radio buttons and labels in a horizontal layout below the filter select.
|
Thanks, and sorry to add to your workload. FWIW, when I started, I was thinking abstractly that the parameter might someday not be boolean if there were a more complicated way to combine filters. I now realize that won't make sense. Or even if it did, can be implemented later. |
|
Yeah, if other "combinators" are thought of, then this can be adjusted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch the new
filterRecordsparameter to a boolean, and adjust the radio values to make that easier to work with.Place the radio buttons and labels in a horizontal layout below the filter select.