Style tweaks for the new tabbed layout of the instructor tools input groups. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…groups. At different window widths there is now a lot of wrapping of the input groups since we have switched back to using the bootstrap grid layout. Particularly with the latest wording changes that make some of the input group texts even longer. So this adjusts the `col` sizes at narrower window widths to prevent that, and allow ample room for translations that might be longer. Make the pill buttons match the width of the scrolling record list above at all layouts, and add a small margin to give them some separation. Add a missing `row` div to contain the `instructor-tools-nav`. In bootstrap's grid layout a `col` must be a direct descendent of a `row` div. Remove the `col-2` on the submit buttons. Those are not direct descendents of a `row` div, and so should not have that class. Furthermore, the `min-width` set in math4.scss overrides that anyway. Make the margin below the scrolling record list match the margin after the pill buttons for even spacing. Fix some overly long lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At different window widths there is now a lot of wrapping of the input groups since we have switched back to using the bootstrap grid layout. Particularly with the latest wording changes that make some of the input group texts even longer. So this adjusts the
colsizes at narrower window widths to prevent that, and allow ample room for translations that might be longer.Make the pill buttons match the width of the scrolling record list above at all layouts, and add a small margin to give them some separation.
Add a missing
rowdiv to contain theinstructor-tools-nav. In bootstrap's grid layout acolmust be a direct descendent of arowdiv. (Hide whitespace changes to minimize the differences shown caused by this.)Remove the
col-2on the submit buttons. Those are not direct descendents of arowdiv, and so should not have that class. Furthermore, themin-widthset in math4.scss overrides that anyway.Make the margin below the scrolling record list match the margin after the pill buttons for even spacing.
Fix some overly long lines.