Skip to content

Commit

Permalink
remove unnecessary parentheses
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex-Jordan committed Dec 17, 2024
1 parent 4cc3d5c commit be2fe03
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 15 deletions.
8 changes: 4 additions & 4 deletions lib/WeBWorK/AchievementItems/ExtendDueDate.pm
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ sub print_form ($self, $sets, $setProblemIds, $c) {

for my $i (0 .. $#$sets) {
push(@openSets, [ format_set_name_display($sets->[$i]->set_id) => $sets->[$i]->set_id ])
if (between($sets->[$i]->open_date, $sets->[$i]->due_date + ONE_DAY())
if (between($sets->[$i]->open_date, $sets->[$i]->due_date + ONE_DAY)
&& $sets->[$i]->assignment_type eq 'default');
}

Expand Down Expand Up @@ -85,11 +85,11 @@ sub use_item ($self, $userName, $c) {
}

# Add time to the reduced scoring date if it was defined in the first place
$userSet->reduced_scoring_date($set->reduced_scoring_date + ONE_DAY()) if $set->reduced_scoring_date;
$userSet->reduced_scoring_date($set->reduced_scoring_date + ONE_DAY) if $set->reduced_scoring_date;
# Add time to the close date
$userSet->due_date($set->due_date + ONE_DAY());
$userSet->due_date($set->due_date + ONE_DAY);
# This may require also extending the answer date.
$userSet->answer_date($userSet->due_date) if ($userSet->due_date > $set->answer_date);
$userSet->answer_date($userSet->due_date) if $userSet->due_date > $set->answer_date;
$db->putUserSet($userSet);

$globalData->{ $self->{id} }--;
Expand Down
12 changes: 6 additions & 6 deletions lib/WeBWorK/AchievementItems/ExtendDueDateGW.pm
Original file line number Diff line number Diff line change
Expand Up @@ -80,21 +80,21 @@ sub use_item ($self, $userName, $c) {
return q{Couldn't find that set!} unless $set && $userSet;

# Add time to the reduced scoring date, due date, and answer date.
$userSet->reduced_scoring_date($set->reduced_scoring_date() + ONE_DAY())
$userSet->reduced_scoring_date($set->reduced_scoring_date() + ONE_DAY)
if defined($set->reduced_scoring_date()) && $set->reduced_scoring_date();
$userSet->due_date($set->due_date() + ONE_DAY());
$userSet->answer_date($set->answer_date() + ONE_DAY());
$userSet->due_date($set->due_date() + ONE_DAY);
$userSet->answer_date($set->answer_date() + ONE_DAY);
$db->putUserSet($userSet);

# Add time to the reduced scoring date, due date, and answer date for all versions.
my @versions = $db->listSetVersions($userName, $setID);

for my $version (@versions) {
$set = $db->getSetVersion($userName, $setID, $version);
$set->reduced_scoring_date($set->reduced_scoring_date() + ONE_DAY())
$set->reduced_scoring_date($set->reduced_scoring_date() + ONE_DAY)
if defined($set->reduced_scoring_date()) && $set->reduced_scoring_date();
$set->due_date($set->due_date() + ONE_DAY());
$set->answer_date($set->answer_date() + ONE_DAY());
$set->due_date($set->due_date() + ONE_DAY);
$set->answer_date($set->answer_date() + ONE_DAY);
$db->putSetVersion($set);
}

Expand Down
4 changes: 2 additions & 2 deletions lib/WeBWorK/AchievementItems/ReducedCred.pm
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ sub print_form ($self, $sets, $setProblemIds, $c) {

for my $i (0 .. $#$sets) {
push(@openSets, [ format_set_name_display($sets->[$i]->set_id) => $sets->[$i]->set_id ])
if (between($sets->[$i]->open_date, $sets->[$i]->due_date + ONE_DAY())
if (between($sets->[$i]->open_date, $sets->[$i]->due_date + ONE_DAY)
&& $sets->[$i]->assignment_type eq 'default');
}

Expand Down Expand Up @@ -97,7 +97,7 @@ sub use_item ($self, $userName, $c) {
unless ($set->reduced_scoring_date && ($set->reduced_scoring_date < $set->due_date));
$userSet->enable_reduced_scoring(1);
# Add time to the close date
$userSet->due_date($set->due_date + ONE_DAY());
$userSet->due_date($set->due_date + ONE_DAY);
# This may require also extending the answer date.
$userSet->answer_date($userSet->due_date) if ($userSet->due_date > $set->answer_date);
$db->putUserSet($userSet);
Expand Down
6 changes: 3 additions & 3 deletions lib/WeBWorK/AchievementItems/SuperExtendDueDate.pm
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ sub print_form ($self, $sets, $setProblemIds, $c) {

for my $i (0 .. $#$sets) {
push(@openSets, [ format_set_name_display($sets->[$i]->set_id) => $sets->[$i]->set_id ])
if (between($sets->[$i]->open_date, $sets->[$i]->due_date + TWO_DAYS())
if (between($sets->[$i]->open_date, $sets->[$i]->due_date + TWO_DAYS)
&& $sets->[$i]->assignment_type eq 'default');
}

Expand Down Expand Up @@ -85,9 +85,9 @@ sub use_item ($self, $userName, $c) {
}

# Add time to the reduced scoring date if it was defined in the first place
$userSet->reduced_scoring_date($set->reduced_scoring_date + TWO_DAYS()) if $set->reduced_scoring_date;
$userSet->reduced_scoring_date($set->reduced_scoring_date + TWO_DAYS) if $set->reduced_scoring_date;
# Add time to the close date
$userSet->due_date($set->due_date + TWO_DAYS());
$userSet->due_date($set->due_date + TWO_DAYS);
# This may require also extending the answer date.
$userSet->answer_date($userSet->due_date) if ($userSet->due_date > $set->answer_date);
$db->putUserSet($userSet);
Expand Down

0 comments on commit be2fe03

Please sign in to comment.