fix(table): cells unresizable after table changed and add cellHandles… #1473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table plugin of v2.28.0 still has resize bugs: table cells are unresizable after table content is changed, and cellHandles is added repeatedly.
I created a codepen to show it. codepen
This bug happened when asynchronously creating a table (such as
$("#editor").trumbowyg('html', string)), or table content has been changed. In addition, correct the CSS selector ofcellhandle.Reason: The
rebuildResizeLayersis emitted via eventtbwchange.tbwTable. And its variables (tableState,targetColumnIndex,$table) used in mouse events come from different closures (caused byhasResizeLayers).