Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken icons into buttons #1821

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

LuizFNJ
Copy link
Collaborator

@LuizFNJ LuizFNJ commented Feb 16, 2025

Description

In this PR, I simply changed the property name from icon to startIcon because icon alone does not work in MUI.

Fixes #1822

before:
Screenshot from 2025-02-15 22-07-01
after:
Screenshot from 2025-02-15 22-07-07
before:
Screenshot from 2025-02-15 21-30-07
after:
Screenshot from 2025-02-15 21-30-12
before:
Screenshot from 2025-02-15 21-29-38
after:
Screenshot from 2025-02-15 21-29-33

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing

Verify that the icons are displayed correctly.

Developer Checklist

General

  • Code is appropriately commented, particularly in hard-to-understand areas
  • Repository documentation has been updated (Readme.md) with additional steps required for a local environment setup.
  • No console.log or related logging is added.
  • No code is repeated/duplicated in violation of DRY. The exception to this is for new (MVP/Prototype) functionality where the abstraction layer may not be clear (comments should be added to explain the violation of DRY in these scenarios).
  • Documented with TSDoc all library and controller new functions

Frontend Changes

  • No new styling is added through CSS files (Unless it's a bugfix/hotfix)
  • All types are added correctly

Backend Changes

  • All endpoints are appropriately secured with Middleware authentication
  • All new endpoints have a interface schema defined

Tests

  • All existing unit and end to end tests pass across all services
  • Unit and end to end tests have been added to ensure backend APIs behave as expected

Merge Request Review Checklist

  • An issue is linked to this PR and these changes meet the requirements outlined in the linked issue(s)
  • High risk and core workflows have been tested and verified in a local environment.
  • Enhancements or opportunities to improve performance, stability, security or code readability have been noted and documented in JIRA issues if not being addressed.
  • Any dependent changes have been merged and published in downstream modules
  • Changes to multiple services can be deployed in parallel and independently. If not, changes should be broken out into separate merge requests and deployed in order.

@LuizFNJ LuizFNJ force-pushed the Fixing-broken-icons-into-buttons branch from d6bac66 to 23b76b8 Compare February 16, 2025 21:36
@thesocialdev thesocialdev merged commit 8269707 into stage Feb 19, 2025
6 of 7 checks passed
@thesocialdev thesocialdev deleted the Fixing-broken-icons-into-buttons branch February 19, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

Bug: Icons missing on some pages
2 participants