Skip to content

Commit

Permalink
CIでLintに失敗したら、ジョブ全体をエラーにする (#1263)
Browse files Browse the repository at this point in the history
  • Loading branch information
KentaHizume authored May 23, 2024
1 parent 962ea7c commit 36d0002
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/build-and-release-documents.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,8 @@ jobs:
with:
fetch-depth: 1

- name: ドキュメントの Lint
- id: lint-documents
name: ドキュメントの Lint
continue-on-error: true
uses: ./.github/workflows/lint-documents

Expand All @@ -59,6 +60,11 @@ jobs:
document-base-path: ${{ env.DOCUMENT_BASE_PATH }}
output-folder-name: ${{ env.DOCUMENT_OUTPUT_FOLDER_NAME }}

- name: Lint結果の成否判定
if: steps.lint-documents.outcome == 'failure'
run: |
exit 1;
- name: ビルドアーティファクトのパッケージングとアップロード
uses: ./.github/workflows/pack-and-upload
with:
Expand Down
8 changes: 7 additions & 1 deletion .github/workflows/build-documents-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ jobs:
with:
fetch-depth: 1

- name: ドキュメントの Lint
- id: lint-documents
name: ドキュメントの Lint
continue-on-error: true
uses: ./.github/workflows/lint-documents

Expand All @@ -57,6 +58,11 @@ jobs:
document-base-path: ${{ env.DOCUMENT_BASE_PATH }}
output-folder-name: ${{ env.DOCUMENT_OUTPUT_FOLDER_NAME }}

- name: Lint結果の成否判定
if: steps.lint-documents.outcome == 'failure'
run: |
exit 1;
- name: ビルドアーティファクトのパッケージングとアップロード
if: github.event_name == 'workflow_dispatch'
uses: ./.github/workflows/pack-and-upload
Expand Down

0 comments on commit 36d0002

Please sign in to comment.