autoconf: Use pkg-config for sdl2 #520
Open
+1
−207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct way to search for sdl2 is pkg-config, as per libsdl-org/SDL#6140 Replace our legacy `AM_PATH_SDL2` macro with `AX_REQUIRE_PKG` and update the minimum version to 2.0.16 to reflect reality. Drop `m4/` since this was our last macro. SDL2 is not optional, remove the only `ifdef SDL` block as without the macro setting that for us we fail to compile. Closes: Aleph-One-Marathon#511 Signed-off-by: Matt Jolly <[email protected]>
|
If you read to the bottom of the linked issue, this is not deprecated in SDL 2. But it's good to keep in mind for when we switch to SDL 3! |
|
It's not yet deprecated however there's also no reason to continue using the old macro when pkg-config "just works". We also haven't redefined the minimum version of sdl2 required in configure in line with recent code changes. Edit: to be clear, this latter part is resulting in downstream failures during a build which should be caught at configure time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct way to search for sdl2 is pkg-config,
as per libsdl-org/SDL#6140
Replace our legacy
AM_PATH_SDL2macro withAX_REQUIRE_PKGand update the minimum versionto 2.0.16 to reflect reality.
Drop
m4/since this was our last macro.SDL2 is not optional, remove the only
ifdef SDLblock as without the macro setting that for us we failto compile.
Closes: #511