Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #96:Fix for Buggy horizontal mode #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RadhikaS
Copy link

Added changes to support horizontal layout.

@defragged
Copy link

I pulled this into my fork and it worked great.

@gabrielrinaldi
Copy link

This fix works great, why don't you accept this?

@evadne
Copy link
Collaborator

evadne commented Sep 29, 2012

Haven’t merged into develop. (It’s accepted.)

On Sep 28, 2012, at 16:59, Gabriel Rinaldi [email protected] wrote:

This fix works great, why don't you accept this?


Reply to this email directly or view it on
GitHubhttps://github.com//pull/103#issuecomment-8998783.

@evadne
Copy link
Collaborator

evadne commented Sep 29, 2012

Thanks for the contribution. After re-reviewing the patch, I regret to say that it might not be pulled into the next master release in its current form due to quality issues. It still contains a lot of useful ideas and I understand that vertical support is an important aspect of the project. It’ll be given priority treatment.

Thanks!

@gabrielrinaldi
Copy link

The problem for me is horizontal scrolling. It does not work, it is broken. I did not make this changes, but I know they work :) (but not if they break something else).

@evadne
Copy link
Collaborator

evadne commented Sep 29, 2012

Thanks, the fix is valuable and I understand that vertical scrolling is just broken now on develop and master.

I’m seeing several issues regarding pulling it immediately into develop or master though: it changes the master instead of develop, and introduces a lot of code specifically dealing with horizontal layout. Also seeing some formatting issues regarding layout code. For now, I highly recommend forking the project, and pulling this change-set into your fork before it is fully integrated.

On Sep 28, 2012, at 5:57 PM, Gabriel Rinaldi [email protected] wrote:

The problem for me is horizontal scrolling. It does not work, it is broken. I did not make this changes, but I know they work :) (but not if they break something else).


Reply to this email directly or view it on GitHub:
#103 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants