Simple paper #158
Merged
Simple paper #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atible with SimpleDruid
PalumboN
commented
Nov 14, 2024
Comment on lines
+69
to
+80
| { #category : #accessing } | ||
| DRStackInstruction >> replaceDependency: anOperand by: anotherOperand [ | ||
|
|
||
| anOperand = anotherOperand ifTrue: [ ^ self ]. | ||
|
|
||
| (self stackDependencies asArray includes: anOperand) ifTrue: [ | ||
| self stackDependencies: (self stackDependencies asArray copyWithout: anOperand). | ||
| self stackDependencies add: anotherOperand. | ||
| ^ self ]. | ||
|
|
||
| super replaceDependency: anOperand by: anotherOperand | ||
| ] |
There was a problem hiding this comment.
I don't like to have the stack dependencies as "general dependencies" (so, at the same level that the operands, for example).
|
Running the tests in SimpleDruid makes the CI timeouts: |
This was referenced Nov 27, 2024
|
I extended the timeout and is working (the half). I merge to continue with the next PR |
|
Yes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes to generate a first version of SimpleDruid.
LoadStackValueandLoadArgumentinstructions generation for n > 1VM chenges: pharo-project/pharo-vm#869