Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stack coallescing #150

Merged
merged 35 commits into from
Jul 5, 2024
Merged

Add stack coallescing #150

merged 35 commits into from
Jul 5, 2024

Conversation

guillep
Copy link
Member

@guillep guillep commented Apr 23, 2024 •
edited
Loading

Coalesce staged stack effects in different branches to allow compilation of static type predictions

  • Add stack coalesce transformation
  • review flush stack hoisting to hoist existing flush instructions too
  • simplify management of exit basic blocks in CFG
  • Add support to unspill stack slots

guillep added 30 commits April 18, 2024 09:01
@guillep
Draft of stack effect coallescing
1c99572
@guillep
Merge fda1378
ed35e70
@guillep
Fix primitive tests
9d22dcb
@guillep
Rename and add tests
f812b73
@guillep
Add tests on stack dependencies
41e0961
@guillep
Merge DRPop and DRPopMany
932b1b9
@guillep
Fix bytecode tests
647cdbc 
 - bytecode compilation should use the default CFG and not the primitive one
 -  refactor IRGenerators to move bytecodeIRGenerator as a sibbling of primitiveIRGenerator
@guillep
Division operands should be mutable
9e2d78b
@guillep
Fix dead block elimination tests
76e40c8
@guillep
Fix linearization tests merge state tests
8895f87
@guillep
Removal of exitBasicBlock step 1
53d65af
@guillep
Fix a dead path test depending on block ids
a8e94de
@guillep
Fix tail duplication tests
e97efa7
@guillep
Fix dead path elimination tests
1e842a5
@guillep
fix loop unrolling tests
817ce42
@guillep
Fix loop invariant code motion tests
074a9a6
@guillep
Remove reliance on single exit block
f651391
@guillep
Fix tail duplication in presence of staged registers
a1d7450
@guillep
Do not tail duplicate stack effect instructions...
19a7422
@guillep
Fix stack coalescing test
793ec52
@guillep
Rename stack dependency accessor
efae63e
@guillep
Properly sorting coalesced stack instructions using a topo sort betwe…
381feb1 
…en stack effect instructions
@guillep
Extend register allocation to take into account staged stack.
4f6a606 
Push instructions extend register lifes until pops or end of code.
@guillep
Extract push and pop instructions from marshalling methods
4726372
@guillep
Recover register allocation of division
c7da575
@guillep
Add support for unspilling slots
96379dc
@guillep
Rework data and stack dependencies for stack operation coallescing
0787ff6
@guillep
Merge 5589445
45c36d2
@guillep
Finish merge with Nahuel's change
f8de5bd 
Update flush hoisting to use new exitBlock implementation
@guillep
Add control on stack flush by moving flush insertion to instruction i…
35bf164 
…nsertion time
@guillep guillep marked this pull request as ready for review June 27, 2024 12:01
PalumboN
PalumboN previously approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@PalumboN PalumboN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coooollllllllll 😳 🎉

Many tests failing 🚨

I left also many comments .... but it's a +3K lines PR, so they are not so many in perspective :P

@guillep
Copy link
Member Author

guillep commented Jul 4, 2024

Ok, I finished the integration of the VM branch improvements.
I'll now focus on integrating these and going over all your comments.

@guillep guillep merged commit 742b6c9 into Alamvic:main Jul 5, 2024
1 of 2 checks passed
@guillep guillep deleted the stackcoallescing branch July 5, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PalumboN PalumboN PalumboN left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guillep @PalumboN