Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent decision making from stale config. #126

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prevent decision making from stale config. #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pglookout/pglookout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,8 @@ def check_cluster_state(self):
self.consider_failover(own_state, master_node, standby_nodes)

def consider_failover(self, own_state, master_node, standby_nodes):
if self._config_version > self._config_version_applied:
self.log.warning("We couldn't apply the latest config version, do not make any decision with outdated config")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we mean to return here? We are not preventing anything with this change :)

if not master_node or not master_node.get("connection"):
# no master node at all in the cluster?
self.log.warning(
Expand Down
Loading