Use TOML versioning #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirikvaa
force-pushed
the
use-toml-versioning
branch
from
e3811ca
to
807a48a
Compare
|
I noticed #11, but that PR is using the Airthings version catalog, which there seemed to be some concerns about, so this PR only adopts TOML versioning but keeps the dependencies in the library. |
sylwester-zielinski
approved these changes
Oct 30, 2024
|
@sylwester-zielinski I forgot to test how this integrates locally, and it complained about too old AGP and Gradle versions, so I'll push those updates as well. |
|
You need to switch Gradle to use Java 17 in AS settings. But yeah, also updating libraries would be nice. |
Yup, I checked and AS is using Java 17. 👍 I can update the rest of the dependencies in a later PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.