Faster locking through .NET 9's System.Threading.Lock

[MarkCiliaVincenti]

No description provided.

[CLAassistant]

All committers have signed the CLA.

[Lulalaby]

Many thanks. Will take a look when I'm back home.
Quick question, is that backwards compatible, since we target net7, net8 & net9 (actually I'm not sure if we even target net 7 anymore)?

[MarkCiliaVincenti]

Many thanks. Will take a look when I'm back home. Quick question, is that backwards compatible, since we target net7, net8 & net9 (actually I'm not sure if we even target net 7 anymore)?

Yes it is. It's a backport of the new System.Threading.Lock. The performance pre net9 will be unaffected but the performance on net9+ will be improved.

[Lulalaby]

Hey there!

I've given this PR many thoughts and came to the conclusion that it's personally a too big possible security risk to depend on such a small package.
Nothing personal, but I would prefer adapting the literally one-file "fix" into DisCatSharp.Common directly, instead of depending on the package.
No hard feelings please.

[MarkCiliaVincenti]

You can. It has an MIT licence. But it goes without saying you won't get potential updates.

[Lulalaby]

That's fine
I'll leave the PR open for a while tho to speak with the other maintainers again

[MarkCiliaVincenti]

I'll amend the PR tomorrow.

[Lulalaby]

Sounds good. We probably still take some time because both me and the other project lead are kinda mid burnout 😅

[MarkCiliaVincenti]

OK done @Lulalaby

[Lulalaby]

Hey! I've reconsidered this pr and will go ahead with the dependency instead, makes it easier for us to automatically manage the updates + doesn't add a new license part.
Thank you!

[MarkCiliaVincenti]

Beautiful! But you should look at the original commit which conditionally doesn't add the dependency for net9

[Lulalaby]

"conditionally doesn't add the dependency for net9" A bit confused about that part, do you mean the change from me with the langversion through Package.targets?

[TheXorog]

@Lulalaby Please disable renovate's auto updates for the newly added package as a security measure.

Thanks for the PR!

[MarkCiliaVincenti]

"conditionally doesn't add the dependency for net9" A bit confused about that part, do you mean the change from me with the langversion through Package.targets?

Code like this so that if compiled for net9 or later won't add the unneeded dependency

<ItemGroup Condition="!$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net9.0'))">
  <PackageReference Include="Backport.System.Threading.Lock" Version="1.1.6" />  
</ItemGroup>

[Lulalaby]

Oh I learned something new today! Haha thanks

[Lulalaby]

@Lulalaby Please disable renovate's auto updates for the newly added package as a security measure.

Thanks for the PR!

7a6633a