Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements Application Emojis (THANKS MAISY).
Breaking change in
DiscordEmoji.TryFromName
(additional required parameter)Added methods, properties & objects
BaseDiscordClient.Emojis
- (IReadOnlyDictionary<ulong, DiscordApplicationEmoji>
)DiscordClient.Emojis
- (IReadOnlyDictionary<ulong, DiscordApplicationEmoji>
)DiscordClient.GetApplicationEmojisAsync(bool fetch = false)
- (Task<IReadOnlyList<DiscordApplicationEmoji>>
)DiscordClient.GetApplicationEmojiAsync(ulong id, bool fetch = false)
- (Task<DiscordApplicationEmoji?>
)DiscordClient.CreateApplicationEmojiAsync(string name, Stream image)
- (Task<DiscordApplicationEmoji>
)DiscordClient.ModifyApplicationEmojiAsync(ulong id, string name)
- (Task<DiscordApplicationEmoji>
)DiscordClient.DeleteApplicationEmojiAsync(ulong id)
DiscordConfiguration.AutoFetchApplicationEmojis
DiscordApplicationEmoji
DiscordApplicationEmoji.ModifyAsync(string name)
- (Task<DiscordApplicationEmoji>
)DiscordApplicationEmoji.DeleteAsync()
DiscordEmoji.FromApplicationEmote(BaseDiscordClient client, ulong id)
- (DiscordEmoji
), can be casted toDiscordApplicationEmoji
Changed methods, properties & objects
DiscordEmoji.RolesInternal
- Will default to[]
meaningRolesInternal.Roles
should never throw an NRE. Made it internalDiscordEmoji.FromName(BaseDiscordClient client, string name, bool includeGuilds = true, bool includeApplication = true)
- (DiscordEmoji
) , can be casted toDiscordUnicodeEmoji
,DiscordGuildEmoji
&DiscordApplicationEmoji
DiscordEmoji.TryFromName(BaseDiscordClient client, string name, bool includeGuilds, bool includeApplication, out DiscordEmoji emoji)
- (DiscordEmoji
) , can be casted toDiscordUnicodeEmoji
,DiscordGuildEmoji
&DiscordApplicationEmoji
| Breaking: Additional required parameterbool includeApplication
Additional
Type of change
Please delete options that are not relevant.
Checklist:
@Aiko-IT-Systems/discatsharp