Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orch Docs Landing Page Clarity, Add transactional vs portfolio #1271

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

amessbee
Copy link
Contributor

@amessbee amessbee commented Feb 17, 2025

Ref: #1272

  • Updated the Orch docs landing page for clarity
  • Add code examples
  • Add transactional vs portfolio page

Here are pages of interest:

Copy link

cloudflare-workers-and-pages bot commented Feb 17, 2025

Deploying documentation with  Cloudflare Pages  Cloudflare Pages

Latest commit: f1b6b5c
Status: ✅  Deploy successful!
Preview URL: https://a018925e.documentation-7tp.pages.dev
Branch Preview URL: https://ms-update-orch-docs.documentation-7tp.pages.dev

View logs

Copy link

github-actions bot commented Feb 17, 2025

Cloudflare deployment logs are available here

@amessbee amessbee force-pushed the ms/update-orch-docs branch from 76d63d7 to 3d34659 Compare February 17, 2025 16:31
@amessbee amessbee changed the title Update Orch Docs for Clarity Update Orch Docs Landing Page for Clarity Feb 17, 2025
@amessbee
Copy link
Contributor Author

@dtribble This is a draft but do you think this is a step in the right direction? Also, please share any specific comments.

@amessbee amessbee force-pushed the ms/update-orch-docs branch from 3d34659 to 1c480c3 Compare February 19, 2025 06:02
@amessbee amessbee force-pushed the ms/update-orch-docs branch from 1c480c3 to 6fa4caf Compare February 19, 2025 06:12
@amessbee amessbee requested a review from rowgraus February 24, 2025 16:06
@amessbee amessbee force-pushed the ms/update-orch-docs branch from da3349e to c5ea9d1 Compare February 25, 2025 16:43
@amessbee amessbee force-pushed the ms/update-orch-docs branch from c5ea9d1 to ced1cac Compare February 26, 2025 15:40
@amessbee amessbee marked this pull request as ready for review March 3, 2025 12:03
@amessbee amessbee requested a review from dckc March 3, 2025 12:03
@amessbee amessbee changed the title Update Orch Docs Landing Page for Clarity Orch Docs Landing Page Clarity, Add transactional vs portfolio Mar 6, 2025
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments marked correctness are critical

Agoric’s Orchestration APIs simplify controlling accounts on remote chains, moving assets, and using capabilities on any chain the API reaches.
Agoric's Orchestration capability allows developers to easily build cross-chain
interactions into existing applications or to create novel cross-chain-focused
products.

<br/>
<img src="./assets/chains.png" width="100%" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be a screenshot or continuous-tone image. It's circles and arrows and such. Do we have an .svg version? How was it drawn? How do we maintain it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was generated in free version of canva so we could not get the SVG.

This image has been here for a few months now - if you recall we had a slack discussion about this with Touseef.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes. now I remember.
Maybe it's worth a comment to say "drawn with canva which does not export SVG" so I don't trip over it again?

or maybe we can convert it... hm... I tried a couple quick tools; no luck.

@amessbee amessbee requested a review from dckc March 10, 2025 11:14
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

I leave it up to you to decide whether to wait for @Chris-Hibbert to weigh in. I expect we can tweak later if it comes to that.

@Chris-Hibbert
Copy link
Collaborator

I've drawn a similar distinction to the idea of transactional vs portfolio here, but I don't think this represents two kinds of contracts. For instance, FastUSDC has both kinds of interactions. The LP holders have a long-term position, while the traders never talk directly to the contract. Their funds are deposited in a seat, but there isn't a separate seat per transaction.

I think of it more as a spectrum. or different types of behavior that a contract can support.

@amessbee amessbee requested a review from Muneeb147 March 12, 2025 09:04
@amessbee
Copy link
Contributor Author

I've drawn a similar distinction to the idea of transactional vs portfolio here, but I don't think this represents two kinds of contracts. For instance, FastUSDC has both kinds of interactions. The LP holders have a long-term position, while the traders never talk directly to the contract. Their funds are deposited in a seat, but there isn't a separate seat per transaction.

I think of it more as a spectrum. or different types of behavior that a contract can support.

@Chris-Hibbert I am adding the following comment in the conclusion:

Note that rather than a rigid dichotomy, many contracts exist on a
spectrum supporting both interaction types. For instance, the FastUSDC contract supports both
portfolio-style LP positions and transactional trades without persistent user state.

Copy link

@Muneeb147 Muneeb147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amessbee Is there any thread/issue where this improvement is pre-discussed? Just wanted to review changes with the context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants