Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: simplify running local chain step in the readme #246

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

toliaqat
Copy link
Contributor

@toliaqat toliaqat commented Mar 6, 2024

No description provided.

Copy link

github-actions bot commented Mar 6, 2024

Network:
Commit: ad16520
Ref: refs/pull/246/merge
IPFS v1 hash: bafybeied3dip4oirjlnzu3svthtbtggtt2cnimeaoukdfettkvo2e533hi
CF - DWeb - 4EVERLAND

@toliaqat toliaqat requested a review from samsiegart March 6, 2024 22:18
Copy link
Collaborator

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this! I've just been using emerynet for testing lately, this will be very helpful. Just a couple comments.

README.md Outdated
```

4. Go the the [wallet](https://github.com/Agoric/wallet-app) repository and start a local client server:
2. Clone and run wallet app
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wallet app isn't necessary anymore, we can remove this step

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsiegart Regarding the process of setting up the web wallet, I have a question. Currently, we set up the web wallet and proceed with our inter dApp test cases for updating/creating/deleting a vault. We're using the web wallet because it has enough ATOMs to serve as collateral. However, I'm wondering if this step might be outdated or if there's another way for provisioning the wallet that we should follow.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The web wallet interfaces with the same account/smart wallet on-chain as the dapp-inter and Keplr, so the ATOM balance isn't a factor. I assume you're using it to provision the smart wallet by paying 10 BLD (and also suggest the local testnet to Keplr). The provisioning step can be done inside dapp-inter via this feature: #219

Adding the local testnet to Keplr I don't think is possible yet with dapp-inter. It should probably be added as a feature if not, but not a blocker for testing if you can do it with the web wallet already.

README.md Outdated
```

5. Open the [wallet UI](http://localhost:3000/wallet/) and adjust Settings to use the localhost network.
3. Open the [wallet UI](http://localhost:3000/wallet/) and adjust Settings to use the localhost network.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this step as well

README.md Outdated
@@ -11,58 +11,27 @@ User application for Agoric Inter Protocol--Vaults, BLD Boost, Liquidations, etc

### Setup

1. Download and build the latest copy of `agoric-sdk`, including Agoric's Cosmic SwingSet.
1. Run the agoric local chain
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we get the keplr seed or access to a faucet now? I think it's worth mentioning here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, i should add getting gov1 mnemonic from the a3p docker.

README.md Outdated

<img width="410" alt="Screen Shot 2023-01-23 at 11 57 16 AM" src="https://user-images.githubusercontent.com/8848650/214137346-b42942db-3b93-413a-991e-c77e2a30d6f1.png">

If you created a Keplr account with the seed from YOUR_ACCOUNT_KEY, you should already have a smart wallet provisioned.

6. Return to this repository and `yarn && yarn dev` to start the local server with Hot Module Replacement (which automatically refreshes the UI as you change source files). To connect to your local wallet UI, use http://127.0.0.1:5173/?wallet=local.
4. Return to this repository and `yarn && yarn dev` to start the local server with Hot Module Replacement (which automatically refreshes the UI as you change source files). To connect to your local wallet UI, use http://127.0.0.1:5173/?wallet=local.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If we delete the wallet-app stuff then change the wording away from "Return to this repository"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants