Merge pull request #136 from AgoraIO-Community/VideoSourceType-breaki…

…ng-change Video source type breaking change
AgoraIO-Community · May 2, 2023 · b51ba32 · b51ba32
2 parents 2d1dd20 + f770211
commit b51ba32
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.3.3
+
+- BREAKING CHANGE: VideoSourceType for `onFirstLocalVideoFrame` callback
+
 ## 1.3.2
 
 - Added callback for cloud recording destination URL

diff --git a/lib/controllers/rtc_event_handlers.dart b/lib/controllers/rtc_event_handlers.dart
@@ -60,9 +60,9 @@ Future<RtcEngineEventHandler> rtcEngineEventHandler(
   }, onFirstLocalAudioFramePublished: (connection, elapsed) {
     agoraEventHandlers.onFirstLocalAudioFramePublished
         ?.call(connection, elapsed);
-  }, onFirstLocalVideoFrame: (connection, width, height, elapsed) {
+  }, onFirstLocalVideoFrame: (videoSourceType, width, height, elapsed) {
     agoraEventHandlers.onFirstLocalVideoFrame
-        ?.call(connection, width, height, elapsed);
+        ?.call(videoSourceType, width, height, elapsed);
   }, onFirstLocalVideoFramePublished: (connection, elapsed) {
     agoraEventHandlers.onFirstLocalVideoFramePublished
         ?.call(connection, elapsed);

diff --git a/lib/models/agora_rtc_event_handlers.dart b/lib/models/agora_rtc_event_handlers.dart
@@ -146,7 +146,7 @@ class AgoraRtcEventHandlers {
   /// * [height] The height (px) of the first local video frame.
   /// * [elapsed] Time elapsed (ms) from the local user calling joinChannel [2/2] until the SDK triggers this callback. If you call startPreview before calling joinChannel [2/2], then this parameter is the time elapsed from calling the startPreview method until the SDK triggers this callback.
   final void Function(
-          RtcConnection connection, int width, int height, int elapsed)?
+          VideoSourceType videoSourceType, int width, int height, int elapsed)?
       onFirstLocalVideoFrame;
 
   /// Occurs when the first video frame is published.

diff --git a/lib/models/agora_rtm_mute_request.dart b/lib/models/agora_rtm_mute_request.dart
@@ -99,7 +99,7 @@ class AgoraUIKit {
   String platform = platformStr();
 
   String framework = "flutter";
-  String version = "1.3.2";
+  String version = "1.3.3";
 
   AgoraUIKit.fromJson(Map<String, dynamic> json)
       : platform = json['platform'],

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,7 +1,7 @@
 name: agora_uikit
 description: Flutter plugin to simply integrate Agora Video Calling or Live
   Video Streaming to your app with just a few lines of code.
-version: 1.3.2
+version: 1.3.3
 homepage: https://www.agora.io/en/
 repository: https://github.com/AgoraIO-Community/VideoUIKit-Flutter