Expand connection retry logic #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #69 +/- ##
===========================================
+ Coverage 68.39% 73.01% +4.62%
===========================================
Files 2 2
Lines 174 189 +15
===========================================
+ Hits 119 138 +19
+ Misses 55 51 -4
☔ View full report in Codecov by Sentry. |
araghukas
force-pushed
the
retry-connect-generalize
branch
from
122ae0d
to
7a58ba4
Compare
for more information, see https://pre-commit.ci
kessler-frost
requested changes
Oct 30, 2023
kessler-frost
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some changes to make the executor more robust.
_client_connect()method a bit, so errors other thanConnectionRefusedErrorcan be caught.execscript into a separate file.(Also addresses issue #61 and covers PR #62 -- both are resolved/included here)