Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend) json-diff evaluator #2001

Merged
merged 7 commits into from
Aug 21, 2024
Merged

fix(backend) json-diff evaluator #2001

merged 7 commits into from
Aug 21, 2024

Conversation

jp-agenta
Copy link
Contributor

Description

  • Converts correct_answer to json before running the evaluator.
  • Adds check to handle BaseResponse with output.data checks.

Related PRs

@jp-agenta jp-agenta requested a review from aybruhm August 19, 2024 12:30
@vercel Vercel
Copy link

vercel bot commented Aug 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
agenta ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 21, 2024 9:16am
agenta-documentation ❌ Failed (Inspect) Aug 21, 2024 9:16am

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 19, 2024
@dosubot dosubot bot added Backend bug Something isn't working labels Aug 19, 2024
@jp-agenta jp-agenta requested a review from aakrem August 19, 2024 12:31
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Aug 20, 2024
aybruhm
aybruhm approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@aybruhm aybruhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix, @jp-agenta!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 20, 2024
@jp-agenta
clean up JSON checks
916d243
@jp-agenta
Merge branch 'fix/json-diff-evaluator-issue-with-json-loads' of githu…
06012f2 
…b.com:Agenta-AI/agenta into fix/json-diff-evaluator-issue-with-json-loads
jp-agenta
jp-agenta commented Aug 21, 2024
View reviewed changes
Copy link
Contributor Author

@jp-agenta jp-agenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :P

@jp-agenta jp-agenta merged commit b776aef into main Aug 21, 2024
9 of 10 checks passed
@jp-agenta jp-agenta deleted the fix/json-diff-evaluator-issue-with-json-loads branch August 21, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aybruhm aybruhm aybruhm approved these changes

@aakrem aakrem Awaiting requested review from aakrem

Assignees
No one assigned
Labels
Backend bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jp-agenta @aybruhm