Allow template docker url to be modified via env #1969
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
|
@tarunwadhwa13 is attempting to deploy a commit to the mmabrouk's projects Team on Vercel. A member of the Team first needs to authorize it. |
aybruhm
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Thank you for the PR, @tarunwadhwa13! Due to the failing tests, I won't be able to merge it. That being said, I'm going to:
- close your PR,
- create a new PR to have the tests run,
- and ensure the PR is properly QA'ed by the team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses - #1964
Allowing docker hub's template URL to be flexible to allow docker proxies to list tags without issues.