Add support for proxy servers #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `trust_env=True` so that AIOHTTP will use the proxy server defined in the environment, if any. If this is not done, the following import will result in a (long) timeout: ```from tokencost import calculate_prompt_cost, calculate_completion_cost```
|
@caramdache Just saw this--- can you clarify what you mean and/or raise a PR? Seems like a simple fix? |
|
It's not such a good idea to have imports that make HTTP calls, as it may be slow or even timeout. Or you could even be behind a proxy server. You need to at least let the http library access the environnement to get the address of the proxy server. Hence the patch. Without it the import will stall for a few minutes before timing out and failing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
trust_env=Trueso that AIOHTTP will use the proxy server defined in the environment, if any.If this is not done, the following import will result in a (long) timeout:
from tokencost import calculate_prompt_cost, calculate_completion_cost