Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX-142 #147

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

BUGFIX-142 #147

wants to merge 3 commits into from

Conversation

tkrevh
Copy link

@tkrevh tkrevh commented Dec 17, 2024

📥 Pull Request

When scaffolding the agents and tasks, empty agent or task name resulted in an exception as documented in this open issue.

📘 Description
Improved text inputs with validations.
Simplified code.

🧪 Testing
Initialized a new agent and entered invalid values.

Improved general text inputs with validations.
Simplified code.
@tcdent
Copy link
Collaborator

tcdent commented Dec 17, 2024

Hi @tkrevh this is great!

Possible to get a test or two to ensure the new methods you introduced continue to operate as expected?

Very simple stuff like we already have in: tests/test_utils.py

Refactored subprocess.run to be cross-platform compatible.
Fixed failing tests on win32.
@tkrevh
Copy link
Author

tkrevh commented Dec 17, 2024

Thank you :)

Added some tests, plus made them cross-platform compatible (they would previously fail on win systems).

======================= 75 passed, 16 skipped in 7.22s ========================
py310: OK + in 12.47 seconds
py311: skipped because could not find python interpreter with spec(s): py311
py311: SKIP ? in 0.11 seconds
py312: skipped because could not find python interpreter with spec(s): py312
py310: OK (12.47=setup[5.06]+cmd[7.41] seconds)
py311: SKIP (0.11 seconds)
py312: SKIP (0.00 seconds)
congratulations :) (12.74 seconds)
(AgentStack)

Would you mind running them on a non-win system to confirm it's ok?

@tcdent
Copy link
Collaborator

tcdent commented Dec 18, 2024

You really went above and beyond on that!

Just ran the actions which test on Linux and we're green.

@tkrevh
Copy link
Author

tkrevh commented Dec 18, 2024

That's great, thank you!

tests/cli_test_utils.py Outdated Show resolved Hide resolved
@bboynton97
Copy link
Contributor

echoing what @tcdent said. absolutely above and beyond on this PR. thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants