-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX-142 #147
base: main
Are you sure you want to change the base?
BUGFIX-142 #147
Conversation
Improved general text inputs with validations. Simplified code.
Hi @tkrevh this is great! Possible to get a test or two to ensure the new methods you introduced continue to operate as expected? Very simple stuff like we already have in: |
Refactored subprocess.run to be cross-platform compatible. Fixed failing tests on win32.
Thank you :) Added some tests, plus made them cross-platform compatible (they would previously fail on win systems). ======================= 75 passed, 16 skipped in 7.22s ======================== Would you mind running them on a non-win system to confirm it's ok? |
You really went above and beyond on that! Just ran the actions which test on Linux and we're green. |
That's great, thank you! |
echoing what @tcdent said. absolutely above and beyond on this PR. thank you for the contribution! |
…was the same across all tests
📥 Pull Request
When scaffolding the agents and tasks, empty agent or task name resulted in an exception as documented in this open issue.
📘 Description
Improved text inputs with validations.
Simplified code.
🧪 Testing
Initialized a new agent and entered invalid values.