Fix uncaught error issue with markbind serve #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangerfile.js violates eslint rules at the moment, perhaps due to something wrong with setup.
Setup development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address the issue MarkBind#2570 in the main upstream repo. In summary, it "catches" the uncaught exception that occurs when a user does
markbind servein a non-MarkBind configured directory.The fix employed currently is to add a
process.exit()after logging the errorNo config file found in parent directories of XXX. The original issue came about because even though this error was caught, the process wouldn't end and the unitialized variablerootFolderwould continue on to the next line, which would trigger the uncaught exception of "The "path" argument must be of type string."