-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numerous fixes to grammar, capitalization and interpunction In docs and pages. #177
base: master
Are you sure you want to change the base?
Numerous fixes to grammar, capitalization and interpunction In docs and pages. #177
Conversation
Aims to improve parity and consistency in written text throughout the project. Minor fixes to .html formatting. (mostly to fix some inconsistencies between different pages.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! there are few changes that block it at the moment. Links must not contain any punctuation, ordering on the tags should not change either as it is important for the CSS.
Refer to the comments i left to see what i'm talking about 👍
<h2 id="trophies"><a class="paragraph-link" href="#trophies">§</a>Trophies</h2> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The order of the two tags is important here, it should not be changed
<img src="trophiesdrop.png" alt=""> | ||
</p> | ||
|
||
</section> | ||
|
||
<section> | ||
|
||
<h2 id="container-refill"><a class="paragraph-link" href="#contaiers-refill">§</a>Containers refill</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here:
@@ -13,13 +13,12 @@ | |||
|
|||
<h1>Random Encounters Reworked bible</h1> | |||
<blockquote>Everything you need to know about RER in a short format!</blockquote> | |||
<a href="./index.html">back to summary</a> | |||
<a href="./index.html">Back to summary.</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Links should not contain dots, they're not a phrase but a button. I don't think a button should contain punctuation. This applies to every back to summary
that was changed. Also capitalization is done by the CSS, unless it is a <p>
then everything should be lowercase
Numerous fixes to grammar, capitalization and interpunction.
Aims to improve parity and consistency in written text throughout the project.
Minor fixes to .html formatting. (mostly to fix some inconsistencies between different pages.)