Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Limited the data item size to labels length if available #350

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🐛 Limited the data item size to labels length if available #350

wants to merge 1 commit into from

Conversation

govind-srinidhi
Copy link
Contributor

📝 Description

  • Whenever the consumer feeds a data item greater than the number of labels, all the building blocks of charts were getting created for that data item.
  • Since this cannot be shown in the alloted space, it led to incorrect rendering of bar/line/grid.
  • So handling this at creation phase from where we feed the data to different chart blocks.

💥 Is this a breaking change (Yes/No):

  • No
  • Yes (please describe the impact and migration path for existing Lume users)

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@govind-srinidhi
🐛 Limited the data item size to labels length if available
aa8d3f2 
* Whenever the consumer feeds a data item greater than the number of labels, all the building blocks of charts were getting created for that data item.
* Since this cannot be shown in the alloted space, it lead to incorrect rendering of bar/line/grid.
* So handling this at creation phase from where we feed the data to different chart blocks.
@govind-srinidhi govind-srinidhi self-assigned this Nov 22, 2023
@govind-srinidhi govind-srinidhi requested a review from a team as a code owner November 22, 2023 15:01
@netlify Netlify
Copy link

netlify bot commented Nov 22, 2023 •
edited
Loading

✅ Deploy Preview for adyen-lume ready!

Name Link
🔨 Latest commit aa8d3f2
🔍 Latest deploy log https://app.netlify.com/sites/adyen-lume/deploys/655e17be96c5370008df5aeb
😎 Deploy Preview https://deploy-preview-350--adyen-lume.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@govind-srinidhi govind-srinidhi added the problem report when a problem report is created label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@govind-srinidhi govind-srinidhi

Labels
problem report when a problem report is created
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@govind-srinidhi