Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/24.3.2 #1136

Merged
merged 12 commits into from
Aug 12, 2024
Merged

Release/24.3.2 #1136

merged 12 commits into from
Aug 12, 2024

Conversation

shanikantsingh
Copy link
Member

@shanikantsingh shanikantsingh commented Aug 9, 2024

Summary

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
  • Compliance with the new Visa Secure Authentication requirements introduced for SFRA customers coming into effect on 12th of August 2024.
  • Included a new Paypal Order property taxTotal to prevent false tax rate calculation in case of delivery address change within the US, where different states have different taxes.
  • update codeowners

Fixed issue: #-SFI-863

amihajlovski and others added 3 commits August 6, 2024 13:17
* feat: provide new fields needed for visa

* fix: unit tests

* fix: don't block holder name for stored cards

* chore: no need for if condition the function returns null if IP not present
* fix(SFI-860): tax calculation for paypal express

* chore(SFI-860): remove unused variables
* fix: removing conditional cardholder name logic and metadata as it is not required anymore

* chore: updated the unit test
Copy link

sonarcloud bot commented Aug 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@shanikantsingh shanikantsingh merged commit 4da8a1d into main Aug 12, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants