Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SFI-469] Domain association apple pay #1012

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

zenit2001
Copy link
Contributor

Describe the changes proposed in this pull request:

  • What is the motivation for this change?
    This change adds the new line at end of apple pay domain association text, which was missing before when saving the domain association to a metadata field.
    Moreover, it sets the content type to text/plain.
  • What existing problem does this pull request solve?
    It solves the issue of Apple Pay domain association not being correctly saved in the metadata field.

Fixed issue: SFI-469

Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zenit2001 zenit2001 marked this pull request as ready for review November 20, 2023 12:48
@zenit2001 zenit2001 added the fix Fixes a bug label Nov 21, 2023
@zenit2001 zenit2001 merged commit c06c42d into develop Nov 27, 2023
14 of 17 checks passed
@zenit2001 zenit2001 deleted the bugfix/SFI-469-domain_association_applepay branch November 27, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants