Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide pin #546

Merged
merged 6 commits into from
Nov 7, 2024
Merged

Hide pin #546

merged 6 commits into from
Nov 7, 2024

Conversation

descorp
Copy link
Contributor

@descorp descorp commented Nov 5, 2024

Open PR

Changes

  • add pinRequired property to partial payment configuration
  • add iOS tests for root configuration and analytics
  • defining analytics as ON unless set otherwise

OscarSpruit
OscarSpruit previously approved these changes Nov 5, 2024
View reviewed changes
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 6, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@descorp descorp merged commit bc7e6d1 into develop Nov 7, 2024
8 checks passed
@descorp descorp deleted the hide_pin branch November 7, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmamont atmamont atmamont approved these changes

@OscarSpruit OscarSpruit OscarSpruit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@descorp @atmamont @OscarSpruit