Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECP-9498] Implement onError callback for the Paypal. #2773

Merged
merged 11 commits into from
Oct 28, 2024
Merged

[ECP-9498] Implement onError callback for the Paypal. #2773

merged 11 commits into from
Oct 28, 2024

Conversation

khushboo-singhvi
Copy link
Contributor

@khushboo-singhvi khushboo-singhvi commented Oct 16, 2024 •
edited by candemiralp
Loading

Description
While abandoning the payment from Paypal, the order is not cancelled, it remains in Pending Payment state until we have the OFFER_CLOSED processed, blocking the inventory. This PR aims to implement onError event being triggered for Paypal cancelation events.

Tested scenarios

  • Canceling or abondoning Paypal orders without completing them
  • E2E automated test case has been implemented on #135

Fixes
#2748

@khushboo-singhvi khushboo-singhvi requested a review from a team as a code owner October 16, 2024 13:57
@khushboo-singhvi khushboo-singhvi linked an issue Oct 16, 2024 that may be closed by this pull request
[ECP-9481] Orders cannot be canceled in v9 #2748
Closed
@khushboo-singhvi khushboo-singhvi changed the title Implement onError callback for the Paypal. [ECP-9498] Implement onError callback for the Paypal. Oct 16, 2024
@candemiralp candemiralp mentioned this pull request Oct 24, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@khushboo-singhvi khushboo-singhvi merged commit 5c2bc8b into main Oct 28, 2024
14 of 16 checks passed
@github-actions github-actions bot mentioned this pull request Oct 24, 2024
Closed
@AdyenAutomationBot AdyenAutomationBot mentioned this pull request Oct 30, 2024
Merged
@candemiralp candemiralp added the Fix Indicates a bug fix label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@candemiralp candemiralp candemiralp approved these changes

@peterojo peterojo peterojo approved these changes

Assignees
No one assigned
Labels
Fix Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ECP-9481] Orders cannot be canceled in v9
3 participants
@khushboo-singhvi @peterojo @candemiralp