Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve network logging #2022

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Improve network logging #2022

merged 1 commit into from
Feb 26, 2025

Conversation

OscarSpruit
Copy link
Contributor

Description

Responses of internal networking will now be logged like below. This will help us to debug backend related things quicker.

2025-02-21 14:50:09.844 15327-15401 CO.OkHttpClient         com.adyen.checkout.example           V  response - 200 .../some/path
2025-02-21 14:50:09.844 15327-15401 CO.OkHttpClient         com.adyen.checkout.example           V  header: value
2025-02-21 14:50:09.844 15327-15401 CO.OkHttpClient         com.adyen.checkout.example           V  another: one
2025-02-21 14:50:09.844 15327-15401 CO.OkHttpClient         com.adyen.checkout.example           V  {"json": "body"}
2025-02-21 14:50:09.844 15327-15401 CO.OkHttpClient         com.adyen.checkout.example           V  response - END

Checklist

  • Changes are tested manually

@OscarSpruit OscarSpruit added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Feb 21, 2025
@OscarSpruit OscarSpruit requested a review from a team as a code owner February 21, 2025 14:08
@OscarSpruit OscarSpruit force-pushed the chore/improve-network-logging branch from 096e1ce to 9a8123e Compare February 21, 2025 14:09
@OscarSpruit OscarSpruit force-pushed the chore/improve-network-logging branch 2 times, most recently from 5dc3977 to a91cda9 Compare February 24, 2025 13:25
@OscarSpruit OscarSpruit force-pushed the chore/improve-network-logging branch from a91cda9 to 07514c3 Compare February 25, 2025 11:42
Copy link
Contributor

The following dependencies have been modified in this PR:

--- 
+++ 
@@ -1,5 +1,3 @@
-Downloading https://services.gradle.org/distributions/gradle-8.12-bin.zip
-.............10%.............20%.............30%.............40%.............50%.............60%.............70%.............80%.............90%.............100%
 androidx.activity:activity-compose:1.10.0
 androidx.activity:activity-ktx:1.10.0
 androidx.activity:activity:1.10.0

To check the affected modules run the dependencyList gradle task with includeModules=true.

Copy link
Contributor

✅ No public API changes

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@OscarSpruit OscarSpruit merged commit b0bcc86 into main Feb 26, 2025
12 of 13 checks passed
@OscarSpruit OscarSpruit deleted the chore/improve-network-logging branch February 26, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants