PayTo - Field validation #2019
Merged
PayTo - Field validation #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COAND-1058
AdyenAutomationBot
added
the
Chore
OscarSpruit
reviewed
Feb 21, 2025
| firstName, | ||
| Validation.Valid | ||
| ) | ||
| private fun validateFirstName(firstName: String): FieldState<String> = if (firstName.isNotEmpty()) { |
There was a problem hiding this comment.
Should we check for isNotBlank() instead maybe?
| private val PHONE_NUMBER_PATTERN = Pattern.compile(PHONE_NUMBER_REGEX) | ||
|
|
||
| @Suppress("ktlint:standard:max-line-length", "MaxLineLength") | ||
| private const val EMAIL_ADDRESS_REGEX = |
There was a problem hiding this comment.
In ValidationUtils we also have regexes for phone numbers and emails. Would it be possible to reuse those?
There was a problem hiding this comment.
The email regex has been reused, but we should keep the phone number regex.
araratthehero
force-pushed
the
chore/payto_view_do_validation
branch
from
4125b59 to
3772fcf
Compare
COAND-1058
araratthehero
force-pushed
the
chore/payto_view_do_validation
branch
from
3772fcf to
2079e0d
Compare
✅ No public API changes |
|
OscarSpruit
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add validation for PayTo fields
Checklist
COAND-1058