[Card scanning] Implementation #2009
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OscarSpruit
added
the
Chore
OscarSpruit
force-pushed
the
feature/card-scanning-implementation
branch
from
a16e715 to
88a257a
Compare
card-scanning/src/main/java/com/adyen/checkout/card/scanning/AdyenCardScanner.kt
Outdated
Show resolved
Hide resolved
card/src/main/java/com/adyen/checkout/card/internal/ui/view/CardView.kt
Outdated
Show resolved
Hide resolved
card/src/main/java/com/adyen/checkout/card/internal/ui/view/CardFragment.kt
Show resolved
Hide resolved
Base automatically changed from
feature/card-scanning-setup-scanner
to
feature/card-scanning
February 19, 2025 10:09
Also add support for fragments in the scanner as we will be using a fragment. COAND-429
Just a simple button is used for now, it will be improved later. COAND-429
OscarSpruit
force-pushed
the
feature/card-scanning-implementation
branch
2 times, most recently
from
6910b18 to
41aee06
Compare
This reduces friction in the flow and is easier to follow. It also reduces object we would have to clean up. COAND-429
OscarSpruit
force-pushed
the
feature/card-scanning-implementation
branch
from
41aee06 to
3711a1a
Compare
✅ No public API changes |
card/src/main/java/com/adyen/checkout/card/internal/ui/view/CardFragment.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The card component now contains a fragment with a button that can handle the activity result from the scanner.
The scanner is wrapped, so that if the
:card-scanningmodule is not present the button won't show and scanning is not possible.The button is not according to design yet and will be replaced later.
wow.mp4
Checklist
COAND-429