Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address lookup view state #1991

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

OscarSpruit
Copy link
Contributor

Description

  • In address lookup selecting a consecutive address from the same country will now update all fields to the latest selection.
  • The input is now retained when changing countries

Checklist

  • Code is unit tested
  • Changes are tested manually

COAND-1064

Release notes

Fixed

  • For address lookup, when selecting a different address it will now correctly update the form's input fields.

Improved

  • For address lookup, the input is now retained when changing countries.

@OscarSpruit OscarSpruit added the Fix [PRs only] Indicates a bug fix label Feb 4, 2025
@OscarSpruit OscarSpruit requested a review from a team as a code owner February 4, 2025 14:59
@OscarSpruit OscarSpruit force-pushed the fix/address_lookup_view_state branch 2 times, most recently from b18ec48 to 401792a Compare February 4, 2025 15:38
This solves an issue where the input fields were not updated if you an address with address lookup
from the same country.

COAND-1064
This will retain all the filled in data, so that a shopper doesn't have to start over
when changing the country.

COAND-1064
This will make sure the data is not retained when navigating back without confirming.

COAND-1064
@OscarSpruit OscarSpruit force-pushed the fix/address_lookup_view_state branch from 401792a to 6eb5856 Compare February 5, 2025 10:32
Copy link

github-actions bot commented Feb 5, 2025

✅ No public API changes

@OscarSpruit OscarSpruit merged commit e5e655d into main Feb 6, 2025
15 checks passed
@OscarSpruit OscarSpruit deleted the fix/address_lookup_view_state branch February 6, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix [PRs only] Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants