Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address Lookup fix infinite loading #1977

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

OscarSpruit
Copy link
Contributor

Description

Reproduction path:

  1. Open card component
  2. Open address lookup
  3. Search "a"
  4. Navigate back
  5. Open address lookup again
  6. Search "a" again
  7. Infinite loading...

IMPORTANT: it turns out this was just a example app issue as we fully delegate the address lookup features to the merchant.

Checklist

  • Changes are tested manually

COAND-1062

@OscarSpruit OscarSpruit added the Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes label Jan 28, 2025
@OscarSpruit OscarSpruit requested a review from a team as a code owner January 28, 2025 10:56
@AdyenAutomationBot AdyenAutomationBot added the Fix [PRs only] Indicates a bug fix label Jan 28, 2025
@OscarSpruit OscarSpruit changed the base branch from main to fix/address_lookup_keyboard January 28, 2025 10:57
@OscarSpruit OscarSpruit removed the Fix [PRs only] Indicates a bug fix label Jan 28, 2025
@OscarSpruit OscarSpruit force-pushed the fix/address_lookup_infinite_loading branch from d7fe9b6 to 269f934 Compare January 28, 2025 10:59
@ozgur00 ozgur00 deleted the branch main January 28, 2025 12:37
@ozgur00 ozgur00 closed this Jan 28, 2025
@OscarSpruit OscarSpruit reopened this Jan 28, 2025
ozgur00
ozgur00 previously approved these changes Jan 28, 2025
Base automatically changed from fix/address_lookup_keyboard to main January 28, 2025 12:53
@OscarSpruit OscarSpruit dismissed ozgur00’s stale review January 28, 2025 12:53

The base branch was changed.

@OscarSpruit OscarSpruit force-pushed the fix/address_lookup_infinite_loading branch from 269f934 to 25010bc Compare January 28, 2025 12:54
Copy link

✅ No public API changes

@OscarSpruit OscarSpruit merged commit b36053b into main Jan 28, 2025
15 checks passed
@OscarSpruit OscarSpruit deleted the fix/address_lookup_infinite_loading branch January 28, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore [PRs only] Indicates any task that does not need to be mentioned in the public release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants