Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Lookup hide keyboard #1973

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Address Lookup hide keyboard #1973

merged 3 commits into from
Jan 28, 2025

Conversation

OscarSpruit
Copy link
Contributor

@OscarSpruit OscarSpruit commented Jan 22, 2025 •
edited
Loading

Description

In Address Lookup the keyboard is now hidden when:

  • an address is selected
  • a search query is submitted
  • the manual entry button is clicked

Checklist

  • If applicable, make sure Breaking change label is added.
  • Changes are tested manually

COAND-873

Release notes

Improved

  • For Address Lookup, the keyboard is now hidden when:
    • an address is selected
    • a search query is submitted
    • the manual entry button is clicked

@OscarSpruit OscarSpruit requested a review from a team as a code owner January 22, 2025 14:58
@OscarSpruit OscarSpruit force-pushed the fix/address_lookup_keyboard branch from a3a5cef to 3daa161 Compare January 22, 2025 14:58
@AdyenAutomationBot AdyenAutomationBot added the Fix [PRs only] Indicates a bug fix label Jan 22, 2025
@ozgur00 ozgur00 closed this Jan 28, 2025
@ozgur00 ozgur00 deleted the fix/address_lookup_keyboard branch January 28, 2025 12:37
@OscarSpruit OscarSpruit restored the fix/address_lookup_keyboard branch January 28, 2025 12:39
@OscarSpruit OscarSpruit reopened this Jan 28, 2025
@github-actions GitHub Actions
Copy link

✅ No public API changes

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@OscarSpruit OscarSpruit merged commit 1894d7e into main Jan 28, 2025
25 of 27 checks passed
@OscarSpruit OscarSpruit deleted the fix/address_lookup_keyboard branch January 28, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozgur00 ozgur00 ozgur00 approved these changes

Assignees
No one assigned
Labels
Fix [PRs only] Indicates a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OscarSpruit @ozgur00 @AdyenAutomationBot