Disassemble .plt section and mark functions as thunks #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSRBerry
commented
Oct 17, 2024
| @@ -274,6 +276,8 @@ protected void setupRelocations() throws AddressOutOfBoundsException, NotFoundEx | |||
| long pltStart = this.pltEntries.get(0).off; | |||
| long pltEnd = this.pltEntries.get(this.pltEntries.size() - 1).off + 0x10; | |||
| this.memBlockHelper.addSection(".plt", pltStart, pltStart, pltEnd - pltStart, true, false, false); | |||
| // Disassemble the entire section, so AARCH64PltThunkAnalyzer works. | |||
There was a problem hiding this comment.
I initially didn't include the part where the thunk functions are created, but even after disassembling the entire section the AARCH64PltThunkAnalyzer wasn't able to create the thunk functions.
So I ended up adding that step as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR hopefully closes #19 by disassembling the entire
.pltsection and creating thunked functions for everyPltEntry.I used ghidra's ElfProgramBuilder as a template and added the necessary steps from it.
That said, I don't know a lot about ELF or file formats in general, so I'm not sure if there are any missing cases or if this solution is incorrect.
I tested it with a few binaries myself and the results look right, but I lack the experience to actually judge that.