Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add destructured array ignore pattern #128

Closed
wants to merge 1 commit into from

Conversation

vinteo
Copy link
Member

@vinteo vinteo commented Sep 2, 2024

Add destructured array ignore pattern to match the arguments ignore pattern

Copy link

sonarcloud bot commented Sep 2, 2024

@vinteo vinteo changed the title [ADS-9534] feat: add destructured array ignore pattern feat: add destructured array ignore pattern Sep 2, 2024
Copy link

@pphminions pphminions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✏️

@xiaofan2406
Copy link
Contributor

for array we can do

const [, theOneToUse] = arr;

we dont need to

const [_theOneToIgnore, theOneToUse] = arr;

@vinteo
Copy link
Member Author

vinteo commented Sep 2, 2024

for array we can do

const [, theOneToUse] = arr;

we dont need to

const [_theOneToIgnore, theOneToUse] = arr;

TIL lol, we discussed this in a tech meeting and no one was aware of this syntax. I guess it doesn't harm to get it in anyway?

@vinteo
Copy link
Member Author

vinteo commented Sep 2, 2024

after discussion, decided not to go ahead with this

@vinteo vinteo closed this Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants