Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Pill component to support latest colors #1856

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

xiaofan2406
Copy link
Contributor

@xiaofan2406 xiaofan2406 commented Sep 10, 2024

Description

  • add Pill props color and inverse

  • deprecated StatusPill

  • removed classnames:

    aui--pill-small
    aui--pill-medium
    aui--pill-large
    aui--pill-clickable
    aui--pill-children
    aui--status-pill
    aui--status-pill-inverse
    aui--status-pill-info
    aui--status-pill-success
    aui--status-pill-warning
    aui--status-pill-error
    aui--status-pill-light
    
  • migration guide

    • StatusPill can be replaced with Pill
    • status prop is children for Pill
    • for displayStyle: "info" | "success" |"warning", it can be replaces with color straighaway
    • for displayStyle: "error" | "light", it becomes color: "danger" | "default" respectively.
    - <StatusPill status="Attention" />
    + <Pill>Attention</Pill>
    - <StatusPill displayStyle="light" />
    + <Pill color="default" />
    - <StatusPill displayStyle="error" />
    + <Pill color="danger" />
    // same for all ["info", "success", "warning"]
    - <StatusPill displayStyle="warning" />
    + <Pill color="warning" />

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@xiaofan2406 xiaofan2406 changed the title Pill update to support latest colors fix: update Pill component to support latest colors Sep 10, 2024
@xiaofan2406 xiaofan2406 force-pushed the update-pill branch 3 times, most recently from e1f2fee to 92cd3ef Compare September 11, 2024 03:29
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (38f5641) to head (bcc74d8).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1856      +/-   ##
==========================================
- Coverage   99.74%   99.74%   -0.01%     
==========================================
  Files         102      101       -1     
  Lines        1962     1959       -3     
  Branches      569      550      -19     
==========================================
- Hits         1957     1954       -3     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiaofan2406 xiaofan2406 force-pushed the update-pill branch 6 times, most recently from bc50bc7 to d112648 Compare September 12, 2024 05:22
Copy link

sonarcloud bot commented Sep 12, 2024

Copy link
Contributor

@pphminions pphminions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌈

@bchew bchew merged commit ac6893a into master Sep 13, 2024
10 checks passed
@bchew bchew deleted the update-pill branch September 13, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants