Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove all default props #1851

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

xiaofan2406
Copy link
Contributor

@xiaofan2406 xiaofan2406 commented Jul 10, 2024

Description

  • convert all class components to function components
  • replace all defaultProps to default function params

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.69%. Comparing base (2c5c7fb) to head (eea3d3e).

Files Patch % Lines
src/components/ConfirmModal/index.jsx 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1851      +/-   ##
==========================================
- Coverage   99.74%   99.69%   -0.06%     
==========================================
  Files         102      102              
  Lines        1962     1961       -1     
  Branches      569      613      +44     
==========================================
- Hits         1957     1955       -2     
- Misses          5        6       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jul 11, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant