Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop project type module #1508

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: drop project type module #1508

wants to merge 1 commit into from

Conversation

knilink
Copy link
Contributor

@knilink knilink commented Oct 19, 2022

Description

drop module type and rename esm file to mjs.
type module will the way how to resolve file with projects installing it, may need more investigation.

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1508 (90828a1) into master (2c88708) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1508   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           97        97           
  Lines         1610      1610           
  Branches       451       451           
=========================================
  Hits          1610      1610           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
17.8% 17.8% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant