Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect or outdated information related to the 'bin/magento config:set' command #132

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TuVanDev
Copy link
Contributor

@TuVanDev TuVanDev commented Sep 3, 2024

Purpose of this pull request

This pull request (PR) removes incorrect or outdated information related to the bin/magento config:set command:

If you use the --lock-env or --lock-config option to set or change a value, you must use the bin/magento app:config:import command to import the setting before you access the Admin or storefront.

Affected pages

@hostep
Copy link
Contributor

hostep commented Sep 3, 2024

Hmm, from what I remember this was actually needed, or was this changed in one of the more recent releases? If yes, I wouldn't remove it, but specify from which version it changed.

@TuVanDev
Copy link
Contributor Author

TuVanDev commented Sep 3, 2024

@hostep Do you recall editing a config file (env.php or config.php) manually, rather than using the command? If we made changes to a config file, we need to import the settings with the bin/magento app:config:import command.

@hostep
Copy link
Contributor

hostep commented Sep 3, 2024

Not sure anymore, it's been too long ago since I executed something like this.

Maybe we'll have to try this on some various Magento versions and see where this was needed and where not. It's not going to be in the docs if this was never needed I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Needs Review
Development

Successfully merging this pull request may close these issues.

2 participants