feat : button block #53
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
| * Decorates the button block. | ||
| * @param {Element} block The calendar block element. | ||
| */ | ||
| export default async function decorate(block) { |
There was a problem hiding this comment.
I'm not sure if we should create a buttonblock. Looking at the markdown file for the test url (https://button-block--adp-devsite--adobedocs.aem.page/developer-distribution/creative-cloud/docs/guides/zxp/distribution), it looks like the button is part of TeaserBlock: https://github.com/AdobeDocs/developer-distribute/blob/main/src/pages/guides/zxp/distribution.md?plain=1#L31-L33
I think this logic should reside within decorateButtons instead. I believe @louisachu had to do something similar for mini-resource-card buttons (#39). @louisachu what are your thoughts?
There was a problem hiding this comment.
@BaskarMitrah after talking with @louisachu, I think I see why you created ButtonBlock. I see in the markdown file, you've replaced TeaserBlock with ButtonBlock.
TeaserBlock was actually merged into Announcement Block (https://jira.corp.adobe.com/browse/DEVSITE-1428).
Could you try
- replacing ButtonBlock with Announcement block here: https://github.com/AdobeDocs/developer-distribute/blob/eds-migration/src/pages/guides/zxp/distribution.md?plain=1#L30
- move ButtonBlock logic within decorateButtons, if still needed
- delete ButtonBlock
- add replacing TeaserBlock with Announcement block to wiki: https://wiki.corp.adobe.com/pages/viewpage.action?spaceKey=AdobeCloudPlatform&title=The+Next+Generation+Developer+Website+-+DevDocs+and+DevBiz#DeveloperWebsite--63309052
and see if that achieves the desired result. Let me know how it goes!
There was a problem hiding this comment.
OKay @melissag-ensemble
Feat : Button Block
Test URL :
https://button-block--adp-devsite--adobedocs.aem.page/developer-distribution/creative-cloud/docs/guides/zxp/distribution