Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Audience migration guide and update API reference #577

Merged
merged 18 commits into from
Aug 11, 2021

Conversation

cacheung
Copy link
Collaborator

@cacheung cacheung commented Jun 23, 2021

Add Audience migration guide and update API reference.

Updated ACPAudience signalWithData example.
@stcheng-adobe @praschetan , can you review the change for this?
#484

https://github.com/Adobe-Marketing-Cloud/aep-sdks-documentation/pull/577/files#diff-2ac8957e9134310547a31cac0393b479f9d02789bbba55dae6d3374dcaab2a63R496

Add Audience migration guide and update API reference
Copy link
Collaborator

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few changes to make!

Updated for the review feedback
cacheung added 9 commits June 29, 2021 17:22
Update code format
Update code block to objectivec
Fix the code block for objective-c
rearrange API for alphabetical order
Update a text format for audience
Fix analytics links issue
….0.2

Update code syntax for ACP 2.x  and add release note for AEPAudience 3.0.2
Add release notes for AEPAudience, AEPMedia and AEPAnalytics
@cacheung cacheung requested a review from calebk1 July 17, 2021 02:09
Copy link
Collaborator

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few comments.

@emdobrin emdobrin requested a review from calebk1 August 2, 2021 18:42
@emdobrin
Copy link
Collaborator

emdobrin commented Aug 2, 2021

@calebk1 is this good to go?

Copy link
Collaborator

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a few comments.

@@ -31,12 +31,18 @@ description: Release notes and change logs for the Adobe Experience Platform Mob
### Android Media 2.1.2

* Enabled debugging post processed data in Media Analytics Assurance workflow.
* Handled reset identities (MobileCore.resetIdentities()) event.
* Added support to handle MobileCore.resetIdentities() API.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with "... to handle the MobileCore.resetIdentities() API."


### iOS AEPAudience 3.0.2

* Added support to handle MobileCore.resetIdentities() API.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with "... to handle the MobileCore.resetIdentities() API."


### iOS AEPAudience 3.0.2

* Added support to handle MobileCore.resetIdentities() API.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with "... to handle the MobileCore.resetIdentities() API."


```objectivec
```objective-c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a correction, but just as a comment - syntax highlighting works for either objectivec or objective-c, it seems - so we don't need to go out of the way to change objectivec to objective-c in the code blocks.

@@ -5,7 +5,7 @@
### Android Media 2.1.2

* Enabled debugging post processed data in Media Analytics Assurance workflow.
* Handled reset identities (MobileCore.resetIdentities()) event.
* Added support to handle MobileCore.resetIdentities() API.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with "... to handle the MobileCore.resetIdentities() API."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@calebk1, can we do the final review and merge? Thanks.

Copy link
Collaborator

@calebk1 calebk1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emdobrin emdobrin merged commit e9d13fe into Adobe-Marketing-Cloud:master Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants