-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Audience migration guide and update API reference #577
Conversation
Add Audience migration guide and update API reference
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few changes to make!
using-mobile-extensions/adobe-audience-manager/audience-manager-api-reference.md
Outdated
Show resolved
Hide resolved
using-mobile-extensions/adobe-audience-manager/audience-manager-api-reference.md
Outdated
Show resolved
Hide resolved
Updated for the review feedback
using-mobile-extensions/adobe-audience-manager/audience-manager-api-reference.md
Show resolved
Hide resolved
Update code format
Update code block to objectivec
Fix the code block for objective-c
rearrange API for alphabetical order
…cumentation into docAudience
Update a text format for audience Fix analytics links issue
…cumentation into docAudience
….0.2 Update code syntax for ACP 2.x and add release note for AEPAudience 3.0.2
Add release notes for AEPAudience, AEPMedia and AEPAnalytics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few comments.
using-mobile-extensions/adobe-audience-manager/audience-manager-api-reference.md
Outdated
Show resolved
Hide resolved
using-mobile-extensions/adobe-audience-manager/audience-manager-api-reference.md
Outdated
Show resolved
Hide resolved
…cumentation into docAudience
updated with comment review
Update media release note
Update with review comment
@calebk1 is this good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a few comments.
release-notes/README.md
Outdated
@@ -31,12 +31,18 @@ description: Release notes and change logs for the Adobe Experience Platform Mob | |||
### Android Media 2.1.2 | |||
|
|||
* Enabled debugging post processed data in Media Analytics Assurance workflow. | |||
* Handled reset identities (MobileCore.resetIdentities()) event. | |||
* Added support to handle MobileCore.resetIdentities() API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go with "... to handle the MobileCore.resetIdentities() API."
release-notes/README.md
Outdated
|
||
### iOS AEPAudience 3.0.2 | ||
|
||
* Added support to handle MobileCore.resetIdentities() API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go with "... to handle the MobileCore.resetIdentities() API."
|
||
### iOS AEPAudience 3.0.2 | ||
|
||
* Added support to handle MobileCore.resetIdentities() API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go with "... to handle the MobileCore.resetIdentities() API."
|
||
```objectivec | ||
```objective-c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a correction, but just as a comment - syntax highlighting works for either objectivec or objective-c, it seems - so we don't need to go out of the way to change objectivec to objective-c in the code blocks.
@@ -5,7 +5,7 @@ | |||
### Android Media 2.1.2 | |||
|
|||
* Enabled debugging post processed data in Media Analytics Assurance workflow. | |||
* Handled reset identities (MobileCore.resetIdentities()) event. | |||
* Added support to handle MobileCore.resetIdentities() API. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd go with "... to handle the MobileCore.resetIdentities() API."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calebk1, can we do the final review and merge? Thanks.
Update with review notes
…cumentation into docAudience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Add Audience migration guide and update API reference.
Updated ACPAudience signalWithData example.
@stcheng-adobe @praschetan , can you review the change for this?
#484
https://github.com/Adobe-Marketing-Cloud/aep-sdks-documentation/pull/577/files#diff-2ac8957e9134310547a31cac0393b479f9d02789bbba55dae6d3374dcaab2a63R496