Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cron to build filters #1070

Merged
merged 2 commits into from
Mar 27, 2025
Merged

added cron to build filters #1070

merged 2 commits into from
Mar 27, 2025

Conversation

105th
Copy link
Member

@105th 105th commented Mar 27, 2025

No description provided.

@105th 105th requested review from ameshkov and Copilot March 27, 2025 12:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces cron schedule triggers to automate the builds for both adguard and 3p filters.

  • Added a cron schedule (every hour at 30 minutes past the hour) for the adguard build workflow
  • Added a cron schedule (every 4 hours) for the 3p build workflow

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/build-adguard.yaml Added a cron trigger to run the adguard build workflow.
.github/workflows/build-3p.yaml Added a cron trigger to run the 3p build workflow.
Comments suppressed due to low confidence (2)

.github/workflows/build-adguard.yaml:11

  • Ensure the 'schedule' key is correctly indented under the 'on:' block so that GitHub Actions properly registers the cron trigger.
  schedule:

.github/workflows/build-3p.yaml:11

  • Verify that the 'schedule' key is properly aligned within the 'on:' block to ensure that the cron trigger runs as intended.
  schedule:

@105th 105th requested a review from Copilot March 27, 2025 12:28
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cron schedule triggers to automate periodic builds for filter workflows and updates the versions of actions used in the workflows.

  • Updates actions/checkout from v3 to v4 and actions/setup-node from v3 to v4 with a higher Node.js version in workflow.yaml.
  • Introduces a scheduled trigger (cron) for the Build AdGuard filters workflow running at 30 minutes past every hour.
  • Introduces a scheduled trigger (cron) for the Build Third-party filters workflow running every 4 hours.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
.github/workflows/workflow.yaml Updated checkout and Node.js setup actions to newer versions
.github/workflows/build-adguard.yaml Added workflow_dispatch and hourly cron schedule for manual builds
.github/workflows/build-3p.yaml Added workflow_dispatch and a 4-hour cron schedule for manual builds

@105th 105th merged commit ecd7ec8 into master Mar 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants