Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitch.tv #383

Closed
zloyden opened this issue Nov 22, 2022 · 57 comments
Closed

twitch.tv #383

zloyden opened this issue Nov 22, 2022 · 57 comments

Comments

@zloyden
Copy link

zloyden commented Nov 22, 2022

AdguardTeam/AdguardFilters#135122
AdguardTeam/AdguardFilters#135722 , especially this AdguardTeam/AdguardFilters#135122 (comment) (pre-roll before stream).
To reproduce this, you should use a European IP, for instance, a German one.

@zloyden
Copy link
Author

zloyden commented Nov 25, 2022

@piquark6046
Copy link
Member

piquark6046 commented Nov 26, 2022

The preroll can be reproduced with a Japanese IP 1 too.

Footnotes

  1. Mullvad VPN

@piquark6046
Copy link
Member

piquark6046 commented Nov 29, 2022

The pre-roll appears on Twitch backend 1.15.0-twitch.1-rc.1 version for me.
Environment: Mozilla Firefox Developer Edition on Desktop, AdGuard Extra (Violentmonkey userscript), AdGuard Base, AdGuard TPF, AdGuard URL Tracking, AdGuard Social, List-KR filter and Mullvad VPN (exit entry: jp-osa-wg-001, multihop mode)
Tested with:
https://www.twitch.tv/radiyu
https://www.twitch.tv/dlddu124
https://www.twitch.tv/flamekr

@kodiakhub
Copy link

kodiakhub commented Nov 29, 2022

The pre-roll appears on Twitch backend 1.15.0-twitch.1-rc.1 version for me. Environment: Mozilla Firefox Developer Edition on Desktop, AdGuard Extra (Violentmonkey userscript), AdGuard Base, AdGuard TPF, AdGuard URL Tracking, AdGuard Social, List-KR filter and Mullvad VPN (exit entry: jp-osa-wg-001, multihop mode) Tested with: https://www.twitch.tv/radiyu https://www.twitch.tv/dlddu124 https://www.twitch.tv/flamekr

Just info, There is also the mid-roll issue that causes the video player to stop buffering, if you trigger it with video player settings change at that time, it will show "commercial break in progress" on video player. Hope you can reproduce this issue too. 👍

Here is video information:
Ex.mp4

@CrazyWolf13
Copy link

Hope for a quick fix, thank you AdGuard devs. and to all who contribute.

@xGiNT0NiCx
Copy link

xGiNT0NiCx commented Dec 27, 2022

https://drive.google.com/file/d/1-W71Bs-xbma0XGHrgAN67JqV3vlfS0rj/view
Here you can see the ads. But I also noticed that when I play around with the video settings(not in this Video), it also turns on ads.
Low latency setting for example.

@zloyden
Copy link
Author

zloyden commented Dec 28, 2022

@stanislav-atr please also take a look at this with VPN AdguardTeam/AdguardFilters#138550.

@ghost

This comment was marked as off-topic.

@CrazyWolf13
Copy link

Bypassed.

?

@xGiNT0NiCx
Copy link

xGiNT0NiCx commented Feb 17, 2023

Any Updates to this ????

@kodiakhub
Copy link

kodiakhub commented Mar 27, 2023

AdGuard Extra: 1.0.506
Chrome v111.0.5563.111

@stanislav-atr pre-roll ads on some streamers:

Video

Preroll.ads.mp4

Edit: Also mid-roll ads:

Screenshot

image

@kodiakhub
Copy link

Hi @stanislav-atr I don't understand, sometimes it shows, sometimes it doesn't. Is Twitch patching too often or is there a similar situation? Can you give information about this? Thanks in advance.

Details

  • Chrome v112.0.5615.87
    • Secure DNS: Cloudflare
  • AdGuard Adblocker v4.1.55
    • AdGuard Base, AdGuard URL tracking, AdGuard Tracking Protection, AdGuard Social media, AdGuard Annoyances, AdGuard Turkish filters.
  • AdGuard Extra v1.0.514
  • Geo: TR

Pre-roll ads show on some streamers but does it not show at other times.

Pre-roll ad video

preroll.mp4

Midrolls ads appears %100 when the streamers advertises manually:

Mid-roll ad video

midroll.mp4

@stanislav-atr
Copy link
Contributor

stanislav-atr commented Aug 2, 2023

#453
#422
#339
#397

This was referenced Aug 2, 2023
This was referenced Aug 2, 2023
@Morku
Copy link

Morku commented Aug 9, 2023

Looks like this will be never fixed. Is this ticket even in progress?

@xGiNT0NiCx
Copy link

Looks like this will be never fixed. Is this ticket even in progress?

I last posted something in December 2022 and it hasn't been fixed since then...

@CrazyWolf13
Copy link

Probably not I switched to pi-hole either, works much better

@kodiakhub
Copy link

Looks like this will be never fixed. Is this ticket even in progress?

I last posted something in December 2022 and it hasn't been fixed since then...

I guess under these circumstances the limits are clear or there is some other reason. To me, ads are blocked but from this rest leftovers are problematic. If you are still having issues, there is another solution that you can check here: github.com/younesaassila/ttv-lol-pro (Proxy Method) 👍

@CrazyWolf13
Copy link

Beta and userscript have been updated

I just gave them a shot, but to be honest my youtube is loading like I live on Mars, everything is like 10x slower and I keep getting there are connection issues on the left bottom warning.

Without the script I do not get them.

@xglossyntx xglossyntx mentioned this issue May 23, 2024
3 tasks
@Samuxle
Copy link

Samuxle commented May 23, 2024

Twitch ads are still not blocked

@jellizaveta
Copy link
Contributor

@Samuxle Which version of AdGuard Extra do you use?

@Samuxle
Copy link

Samuxle commented May 27, 2024

@SamuxleQuale versione di AdGuard Extra usi?

@jellizaveta The latest version and I still have the ads

@jellizaveta
Copy link
Contributor

@Samuxle Could I ask you to let me know which version of the extension (number) you're using, the device and browser in which the adverts appear and the IP address where the adverts can be reproduced?

@Samuxle
Copy link

Samuxle commented May 27, 2024

@jellizaveta I'm on Android I use adguard app with adguard extra (version 1.0.605) for ads on the Twitch app

@jellizaveta
Copy link
Contributor

@Samuxle App not fixable, please use browser version

@Samuxle
Copy link

Samuxle commented Jun 3, 2024

@jellizaveta How is this possible given that until recently when it no longer worked you fixed it

@Samuxle
Copy link

Samuxle commented Jun 3, 2024

@jellizaveta Every time I update the adguard extra filter version

@Samuxle
Copy link

Samuxle commented Jun 25, 2024

@jellizaveta It started working again a couple of days ago until last night but last night it stopped working (I use userscript on adguard)

@Samuxle
Copy link

Samuxle commented Jul 20, 2024

there is still the problem that the adv start anyway

@jellizaveta
Copy link
Contributor

@Samuxle Hello. I just want to make sure I understand. Are we talking about the app or the browser version?

@Samuxle
Copy link

Samuxle commented Jul 22, 2024

@jellizaveta From the adguard app where I use adguard extra as an extension, for a long time it blocked ads on the Twitch app from Android but until yesterday it didn't work, today I saw that the extensions have been updated and tonight I will try to see if it works

@jellizaveta
Copy link
Contributor

@Samuxle Please note the comment above, the AdGuard app does not filter ads in the twitch app because it may affect the functionality of the app. AdGuard Extra only works in the browser.

@Samuxle
Copy link

Samuxle commented Jul 22, 2024

@jellizaveta For a long time, however, it worked

@Samuxle
Copy link

Samuxle commented Jul 24, 2024

@jellizaveta
IMG_20240724_211314_948~2
Now the filter update is out and it works

@jellizaveta
Copy link
Contributor

@Samuxle nothing changed for twitch

@kodiakhub
Copy link

@jellizaveta There is mid-roll ads freeze issue. See:

Video (With sound)

T.mp4

In this case, it can be fixed by manually pausing and playing.

Firefox 131.0.3
Tampermonkey 5.3.1 (AdGuard Extra v1.0.644 beta)
twitch.tv/loltyler1

Just in case, there is similar issue: pixeltris/TwitchAdSolutions#292

@jellizaveta
Copy link
Contributor

@kodiakhub Hello. Could you please send saved page to [email protected]

@kodiakhub
Copy link

@kodiakhub Hello. Could you please send saved page to [email protected]

Done, subject name: AdGuardExtra/issues/383 @jellizaveta

@jellizaveta
Copy link
Contributor

@kodiakhub Hello. I have sent a version of AdGuard Extra with a possible fix to your mail. Could you please test it via Tampermonkey extension?

@kodiakhub
Copy link

@kodiakhub Hello. I have sent a version of AdGuard Extra with a possible fix to your mail. Could you please test it via Tampermonkey extension?

I didn't receive anything. 🙂

@jellizaveta
Copy link
Contributor

@kodiakhub Ohh… Could you please send a mail, maybe I sent it to the wrong address?

@jellizaveta
Copy link
Contributor

@kodiakhub thank you, re-sent.

@kodiakhub
Copy link

kodiakhub commented Nov 6, 2024

@jellizaveta Tested and i think it got better. However, it is not perfect, rarely I still saw the video buffering, but then it continued on its own as like the ads were over and sometimes freeze. See test videos:

Video 1 (Successful blocking)

Test.1.mp4

Video 2 (First phase ad-roll failed to correctly block, second phase successful blocking)

Test.2.mp4

I guess, i will switch to Brave 😄, due to this: pixeltris/TwitchAdSolutions#292 (comment) and AdguardTeam/AdguardFilters#190301 (comment)

Update: Tested brave works way way better. (AdGuard Extra 1.0.644 extension) 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests