-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added drivers command #221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: drivers.yaml file added: DriverHelper for drivers command updated: README with newly added command
nbesimi
reviewed
May 16, 2024
@@ -413,6 +419,39 @@ private void diff(@CommandLine.Option(names = {"-s", "--source"}) String sourceN | |||
} | |||
} | |||
|
|||
@CommandLine.Command(name = "drivers", description = "Show available drivers for download", mixinStandardHelpOptions = true) | |||
private void drivers(@CommandLine.Option(names = {"--list"}, description = "Used to list all available drivers") boolean isList, | |||
@CommandLine.Option(names = {"--download"}, description = "Used to download selected driver by index") boolean isDownload, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we need a shortcut for --download
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree, should we add -dl
?
…file after completion
modified: README to include an example for drivers.yaml
nbesimi
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added: drivers command (--list, --download)
added: drivers.yaml file
added: DriverHelper for drivers command
updated: README with newly added command